Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use executor from arg in then_on/rescue_on/chain_on for Promises #1005

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Use executor from arg in then_on/rescue_on/chain_on for Promises #1005

merged 1 commit into from
Nov 17, 2023

Conversation

tgwizard
Copy link
Contributor

When doing some spelunking through the code I saw that these 3 methods don't use the executor passed in through the argument. I believe they should, as the other *_on methods do.

eregon
eregon approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this code but yeah looking at it it makes a lot of sense, thanks for the fix!

@eregon eregon merged commit 53a67a1 into ruby-concurrency:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgwizard @eregon